Skip to content

🐛Storage: fix access to DatCore #7213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2025
Merged

🐛Storage: fix access to DatCore #7213

merged 3 commits into from
Feb 12, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Feb 12, 2025 •
edited
Loading

What do these changes do?

After #7088 the access to Datcore was broken. This PR fixes it.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:storage issue related to storage service label Feb 12, 2025
@sanderegg sanderegg added this to the Singularity milestone Feb 12, 2025
@sanderegg sanderegg self-assigned this Feb 12, 2025
@sanderegg sanderegg enabled auto-merge (squash) February 12, 2025 07:35
@sanderegg sanderegg mentioned this pull request Feb 12, 2025
Closed
21 tasks
@codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (f9f5df3) to head (eaa264e).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7213      +/-   ##
==========================================
+ Coverage   76.84%   80.42%   +3.57%     
==========================================
  Files        1313      688     -625     
  Lines       52971    33023   -19948     
  Branches      566      168     -398     
==========================================
- Hits        40706    26558   -14148     
+ Misses      12115     6407    -5708     
+ Partials      150       58      -92
Flag Coverage Δ
integrationtests 65.32% <ø> (+0.01%) ⬆️
unittests 79.80% <50.00%> (-10.24%) ⬇️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.31% <ø> (ø)
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.54% <ø> (+0.01%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 86.28% <50.00%> (∅)
webclient ∅ <ø> (∅)
webserver 79.36% <ø> (+20.18%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f5df3...eaa264e. Read the comment docs.

pcrespov
pcrespov approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sanderegg sanderegg force-pushed the storage/fix-list-locations branch from 7f54894 to eaa264e Compare February 12, 2025 09:57
@sanderegg sanderegg disabled auto-merge February 12, 2025 09:57
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 12, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit 5726949 into ITISFoundation:master Feb 12, 2025
6 checks passed
@sanderegg sanderegg deleted the storage/fix-list-locations branch February 12, 2025 09:58
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@sanderegg @mrnicegyu11
🐛Storage: fix access to DatCore (ITISFoundation#7213)
4468232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

Assignees

@sanderegg sanderegg

Labels

a:storage issue related to storage service

Projects

None yet

Milestone

Singularity

Development

Successfully merging this pull request may close these issues.

4 participants

@sanderegg @giancarloromeo @GitHK @pcrespov